Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • kado kado
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • kado
  • kadokado
  • Merge requests
  • !244

Add Multipart to replace Mutliparse

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Bryan Tong requested to merge nullivex/kado:addMultipart into master Jul 26, 2020
  • Overview 4
  • Commits 12
  • Pipelines 12
  • Changes 24

My reasoning behind this stems from a few issues. The Multiparse system is setup to URL Decode as well as Form Data parsing. However, the URL Decoding is already being performed by the Router.standardPreparation() method. There should not be dual code for this purpose. Second, the Multiparse.Multipart class had scoping issues from previously being done in es5. This class re-implements the functionality but flattens Multiparse and Multiparse.Multipart into a single class. This makes the event emission easier. The overall scoping is now tighter and there is no hoisting of this into self or that.

Docs and tests are still missing.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: addMultipart