Commit 1658f9c9 authored by Bryan Tong's avatar Bryan Tong
Browse files

Merge branch 'fixMultipartTest' into 'master'

Fix Multipart testing on Windows 10 using Node 16.4.2

See merge request kado/kado!308
parents 10d0a91a ece55a66
Pipeline #8435 passed with stage
in 2 minutes and 33 seconds
......@@ -131,7 +131,18 @@ const sendUpload = (headers, data, resolve, reject) => {
})
})
if (data instanceof Stream) {
data.pipe(client)
// piping from a file fails on Windows 10 with Node 16.4.2 it may be
// a bug that will go away, or it might be a miracle that it works the rest
// of the time. issue https://git.nullivex.com/kado/kado/-/issues/90
// and merge request
// https://git.nullivex.com/kado/kado/-/merge_requests/289/
// both attempt to correct this mysterious issue however it remains.
// the theory is that a race condition happens, and the newest code is
// exposing what used to be a rare issue
// data.pipe(client)
// reading and writing the stream manually works
data.on('data', (chunk) => { client.write(chunk) })
data.on('close', () => { client.end() })
} else {
client.end(data)
}
......
......@@ -58,7 +58,7 @@ _runner.suite('TestRunner', (main) => {
test2.it('should do more stuff', () => { Assert.eq() })
// and again
const test3 = test2.suite('something really deep')
test3.it('that is what she said', () => { Assert.eq() })
test3.it('that is deep', () => { Assert.eq() })
runner.test('something out of band', () => { Assert.eq(false, false) })
runner.test('something out of band 2', () => { Assert.eq(false, true) })
Assert.eq(await runner.execute({ indent: indent, hideFailed: true })
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment